Added support for renameat2 on linux #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Jul 4, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Can you please remove formatting changes from the PR?
Author
Of course, yes. Done. |
asomers
requested changes
Jul 5, 2021
tomboland
pushed a commit
to tomboland/nix
that referenced
this pull request
Jul 5, 2021
…for any cross-compile targets, as per comment here: nix-rust#1458 (comment)
Member
|
Ok, it looks good. Would you mind squashing your commits, and rebasing to fix the CHANGELOG? |
tomboland
force-pushed
the
feature/add-renameat2
branch
from
5c3f183 to
80b1f28
Compare
Author
Thank you @asomers . That's done now, and everything looks clean! |
asomers
requested changes
Jul 8, 2021
tomboland
force-pushed
the
feature/add-renameat2
branch
from
c870dde to
1a23312
Compare
Contributor
|
Canceled. |
Author
Apols. I squashed my commits in to one again and interrupted this. |
Member
|
bors retry |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, please find my PR for adding the linux-specific
renameat2syscall. It's largely similar torenameat, with an additional flags parameter:The flags are:
PLEASE NOTE: It looks like my formatter has made numerous changes. If you have a preferred formatting config then please let me know, and I can push up changes consistent with the accepted style.
I'm not all that experienced with rust, and this is my first time looking at the nix project, so I'm more than happy to receive guidance on improving my submission.
Cheers!